Quality improvements for az aks extension and az aks extension type command groups#8794
Merged
zhoxing-ms merged 179 commits intoAzure:mainfrom May 30, 2025
Merged
Conversation
added 30 commits
March 25, 2021 14:58
FumingZhang
reviewed
May 28, 2025
| @@ -16176,4 +16176,4 @@ def test_aks_loadbalancer_commands( | |||
| # self.cmd( | |||
Member
There was a problem hiding this comment.
please remove self.cmd('extension add -n k8s-extension') from the init function.
Member
There was a problem hiding this comment.
Also, for cases where you need to install an extension, I recommend marking them as @live_only() and you can remove the corresponding recording file
added 4 commits
May 28, 2025 17:18
…into sophiezhao/coreExtensions
matthchr
reviewed
May 28, 2025
Member
matthchr
left a comment
matthchr
left a comment
There was a problem hiding this comment.
I think the _backup.yaml files aren't intentionally added?
added 2 commits
May 28, 2025 21:30
github-actions
bot
added
the
release-version-block
added 4 commits
May 29, 2025 12:51
…into sophiezhao/coreExtensions
github-actions
bot
removed
the
release-version-block
FumingZhang
approved these changes
May 30, 2025
4 tasks
zhoxing-ms
approved these changes
May 30, 2025
Collaborator
|
[Release] Update index.json for extension [ aks-preview-18.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125793617&view=results |
bavneetsingh16
pushed a commit
to AzureArcForKubernetes/k8s-extension
that referenced
this pull request
May 30, 2025
…ommand groups (Azure#8794) * add troubleshoot command under connectedk8s * resolve check issues * fix final new line * add back troubleshoot params * implement helm version and permission checks * add aks extension and aks extension type cli groups * fix pylint * POC for extensions * fix formatting * add test and revert connectedk8s changes * remove newline from readme * fix linter issue * fix faulty examples * fix linting issues * fix parse issue * fix * fix help.py * fix more pylint issues * fix params * fix parameter issue * fix the over indent * fix pylint issue * resolve pylinter issue * remove location * remove location * add extension type * remove unrecognized parameter * add comma * fix invalid naming convensitons * fix pylinter issue * remove duplicate functions from k8sextension * add check for allowed extensions * revise tests * fix indentation issue * fix trailing whitespace * cmmit * add params * change * fix format.py * remove aks group * fix format.py * add library func for params * add const * remove libraries * update format.py * remove libraries from format.py * add check for allow list of extensions * add history.rst * fix unit test * fix style in help.py * fix extension type test * add cassete file * add modified tests * add cmd for patching the k8s extension * fix cassette file * add update * fix PR comments in format, help.py * fix style * fix action.py * fix style * add newline in params.py * update extension type command * fix pylint indentation * fix cli examples * add resource group name as param * add resource group param * add autoupgrade as description * fix autoupgrade param * add abreviation * fix option list * add autoupgrade * change autoupgrade order * add description for config settings * specify additional parameters * add examples for aks extension API * rerun pylinter * rerun pipeline * fix style and pylint issue * add location param in help.py * add region as param * run new command with style and linter * add command group * make parameters optional * use custom show command * rerun style check * fix style * fix unexpected spaces * remove extra show extension type commands * fix params in extension types api * add show version command * fix style * fix extension list version command * fix style and linting issue * fix aks test cases * print allowed list of extensions * fix help.py description * fix pylinting issue * fix style issue * fix style issue * add new cassette files * commit action.py * add backup scenario * add extension type version API commands * fix help.py examples * fix help.py * fix version summary * remove print statement * add version show * add custom helper function * fix new line issue * remove show-version and list-versions * fix style issue * fix style issue * fix style issue * location of extension * fix pylinting issue * fix location flag * Update src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com> * Update src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com> * add extension type filtering for core extensions * remove 3 properties * fix style * add missing custom functions * upload cassette files * change pending version * modify casette files * add k8s extension firewall * add latest cassette files * remove secrets from test case * register extension types feature * add a wait period for the feature to register * update version in setup.py * fix cassette files * update history.rst * commit * add validation * update cassette files * update history.rst * fix style issue in helpers.py * change api version * update casset files with correct API verisons * address PR comments * update setup.py * remove extra test files * update casette files * make tests live only * fix style issue * fix setup.py * fix history.rst * fix style * fix failed test case * fix syntax error * update failed test * fix * fix recording * revert yaml changes * fix put call API * update api verisons * update api version --------- Co-authored-by: Sophie Zhao <sophiezhao@microsoft.com> Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following improvements for the az aks extension and az aks extension type command groups:
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.